Merged
Conversation
codingjoe
requested review from
amureki and
Copilot
and removed request for
Copilot
Member
|
@codingjoe thanks! Could you address failing checks? |
This reverts commit 6bc77cf.
codingjoe
force-pushed
the
revert-crontask
branch
from
dffc3f5 to
b8d137e
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes accidental crontask/django-tasks remnants and standardizes the repo around dramatiq_crontab (Dramatiq-based scheduling), updating tests, packaging metadata, and CI accordingly.
Changes:
- Replace remaining
crontaskimports/settings/command usage withdramatiq_crontabequivalents. - Update project metadata (package name/module path, supported Python/Django versions) and CI matrix.
- Refresh docs/assets to match the Dramatiq Crontab identity.
Reviewed changes
Copilot reviewed 18 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testapp/tasks.py | Switch test app task decoration/imports to Dramatiq + dramatiq_crontab.cron. |
| tests/testapp/settings.py | Replace CRONTASK/django-tasks settings with DRAMATIQ_CRONTAB and configure a stub broker for tests. |
| tests/test_utils.py | Update test imports from crontask to dramatiq_crontab. |
| tests/test_tasks.py | Update scheduler/task imports and heartbeat invocation to Dramatiq-based tasks. |
| tests/test_commands.py | Rename management command usage to crontab and update lock key expectations. |
| pyproject.toml | Rename distribution/module, expand supported Python/Django, and update dependencies/extras. |
| images/logo-light.svg | Remove old logo asset tied to previous branding. |
| images/logo-dark.svg | Remove old logo asset tied to previous branding. |
| dramatiq_crontab/utils.py | Fix config import and update Redis lock name. |
| dramatiq_crontab/tasks.py | Add Dramatiq heartbeat actor scheduled via cron. |
| dramatiq_crontab/management/commands/crontab.py | Update imports/job naming/app-skip logic to dramatiq_crontab. |
| dramatiq_crontab/conf.py | Read configuration from DRAMATIQ_CRONTAB setting. |
| dramatiq_crontab/init.py | Adapt decorators to work with Dramatiq actors (actor.send, actor.fn). |
| README.md | Update documentation and badges for dramatiq-crontab usage/branding. |
| LICENSE | Update copyright header. |
| .gitignore | Update ignored version file path for renamed module. |
| .github/workflows/ci.yml | Update supported Python/Django matrix to align with new constraints. |
| .github/dependabot.yml | Increase Dependabot update frequency (weekly → daily). |
| .github/FUNDING.yml | Add funding configuration. |
| .github/CODEOWNERS | Add code ownership rules for key files. |
Comments suppressed due to low confidence (1)
tests/test_tasks.py:15
tasks.heartbeatis a Dramatiq actor; calling it (tasks.heartbeat()) enqueues a message and will not execute the function body, so the expected log line won't be emitted. For this test, call the underlying function (e.g.,tasks.heartbeat.fn()) or explicitly run/process the queued message with the stub broker before asserting on logs.
def test_cron__stars():
assert not scheduler.remove_all_jobs()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Collaborator
Author
My main was a couple of commits behind. I redid the revert. |
amureki
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow the crontask commits made it into this repo. I checked; I don't have a second remote setup. I don't really know how it happened, but those 3 commits need to go.
Sorry for the inconvenience.